Skip to content

Direct ptycho visualize and rotation#249

Merged
smribet merged 7 commits into
electronmicroscopy:diffractive_imagingfrom
smribet:direct_ptycho_refactor
Jun 15, 2026
Merged

Direct ptycho visualize and rotation#249
smribet merged 7 commits into
electronmicroscopy:diffractive_imagingfrom
smribet:direct_ptycho_refactor

Conversation

@smribet

@smribet smribet commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

What problem this PR addreseses

This PR makes direct and iterative ptycho more consistent by changing direct ptycho to degrees and adding a visualize function.

FWIW I did some testing yesterday, and I think the direction of aberrations is consistent between abTEM, direct, and iterative ptycho, but others should confirm as well.

What should the reviewer(s) do

Merge the code and provide feedback.
visualize_output

@gvarnavi gvarnavi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Steph, looks good to me!

Note aberration axes still need to be specified in radians, but I think we should leave this to match abTEM.

# ground truth
known_aberration_coefs = {
    "C10": 200,
    "C12": 100,
    "phi12": np.deg2rad(11)
}
known_rotation_angle = -13

Updated tutorials to match: electronmicroscopy/quantem-tutorials#11

Feel free to merge both when ready.

@smribet

smribet commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator Author

I agree aberrations in radians makes sense. Thanks for the feedback @gvarnavi!

@smribet
smribet merged commit c9b4f1e into electronmicroscopy:diffractive_imaging Jun 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants