Direct ptycho visualize and rotation#249
Merged
smribet merged 7 commits intoJun 15, 2026
Merged
Conversation
gvarnavi
approved these changes
Jun 15, 2026
gvarnavi
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Steph, looks good to me!
Note aberration axes still need to be specified in radians, but I think we should leave this to match abTEM.
# ground truth
known_aberration_coefs = {
"C10": 200,
"C12": 100,
"phi12": np.deg2rad(11)
}
known_rotation_angle = -13Updated tutorials to match: electronmicroscopy/quantem-tutorials#11
Feel free to merge both when ready.
Collaborator
Author
|
I agree aberrations in radians makes sense. Thanks for the feedback @gvarnavi! |
smribet
merged commit Jun 15, 2026
c9b4f1e
into
electronmicroscopy:diffractive_imaging
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem this PR addreseses
This PR makes direct and iterative ptycho more consistent by changing direct ptycho to degrees and adding a visualize function.
FWIW I did some testing yesterday, and I think the direction of aberrations is consistent between abTEM, direct, and iterative ptycho, but others should confirm as well.
What should the reviewer(s) do
Merge the code and provide feedback.
