Skip to content

fix(components): [popover] omit gpuAcceleration default value - #24636

Merged
keeplearning66 merged 1 commit into
devfrom
fix/popover-omit-gpuAcceleration-default-value
Jul 30, 2026
Merged

fix(components): [popover] omit gpuAcceleration default value#24636
keeplearning66 merged 1 commit into
devfrom
fix/popover-omit-gpuAcceleration-default-value

Conversation

@btea

@btea btea commented Jul 30, 2026

Copy link
Copy Markdown
Member

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

rel #24571

Summary by CodeRabbit

  • Bug Fixes
    • Updated popover default settings to prevent an unsupported GPU acceleration option from being applied.
    • Improves consistency and reliability in popover positioning behavior.

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5aac31f1-6780-4611-8f38-494cf38a854a

📥 Commits

Reviewing files that changed from the base of the PR and between cfc52cd and ef66fac.

📒 Files selected for processing (1)
  • packages/components/popover/src/popover.ts

📝 Walkthrough

Walkthrough

Popover default prop composition now excludes gpuAcceleration from the tooltip content defaults.

Changes

Popover defaults

Layer / File(s) Summary
Compose Popover defaults
packages/components/popover/src/popover.ts
popoverPropsDefaults omits gpuAcceleration from useTooltipContentPropsDefaults.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: Needs Review

Suggested reviewers: jungzl

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change: removing the default gpuAcceleration value from Popover.
Description check ✅ Passed The description follows the template and includes the required issue reference #24571.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/popover-omit-gpuAcceleration-default-value

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Jul 30, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/element-plus@24636
npm i https://pkg.pr.new/element-plus@24636
yarn add https://pkg.pr.new/element-plus@24636.tgz

commit: ef66fac

@github-actions

Copy link
Copy Markdown
Contributor

Size Change: +38 B (0%)

Total Size: 1.44 MB

📦 View Changed
Filename Size Change
dist/element-plus/dist/index.full.js 416 kB +13 B (0%)
dist/element-plus/dist/index.full.min.js 291 kB +8 B (0%)
dist/element-plus/dist/index.full.min.mjs 284 kB +9 B (0%)
dist/element-plus/dist/index.full.mjs 406 kB +8 B (0%)
ℹ️ View Unchanged
Filename Size
dist/element-plus/dist/index.css 47.4 kB

compressed-size-action

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 86.29% 18847 / 21839
🔵 Statements 85.12% 19691 / 23131
🔵 Functions 84.73% 4978 / 5875
🔵 Branches 75.79% 10974 / 14479
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/components/popover/src/popover.ts 100% 100% 100% 100%
Generated in workflow #3557 for commit ef66fac by the Vitest Coverage Report Action

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Playground Preview: https://element-plus.run/?pr=24636
Please comment the example via this playground if needed.

🔖 Commit: ef66fac334ee6e88208b6e4dbe1e616619da1b38

@keeplearning66
keeplearning66 merged commit 115087c into dev Jul 30, 2026
17 checks passed
@keeplearning66
keeplearning66 deleted the fix/popover-omit-gpuAcceleration-default-value branch July 30, 2026 08:16
@github-actions

Copy link
Copy Markdown
Contributor

@btea Thanks for your contribution! ❤️

@element-bot element-bot mentioned this pull request Aug 7, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants