Skip to content

export El dependency on GMP, MPFR, MPC, QG, and Valgrind include dirs#249

Merged
poulson merged 1 commit intoelemental:masterfrom
ValeevGroup:master
Nov 23, 2017
Merged

export El dependency on GMP, MPFR, MPC, QG, and Valgrind include dirs#249
poulson merged 1 commit intoelemental:masterfrom
ValeevGroup:master

Conversation

@evaleev
Copy link
Copy Markdown
Contributor

@evaleev evaleev commented Nov 23, 2017

No description provided.

Copy link
Copy Markdown
Member

@poulson poulson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I am somewhat blindly merging since the tests pass (though I had to restart them due to Travis flakiness).

@poulson poulson merged commit 50e24bb into elemental:master Nov 23, 2017
@evaleev
Copy link
Copy Markdown
Contributor Author

evaleev commented Nov 23, 2017

Jack, thanks for a super quick turnaround!

This fix should only affect external uses of Elemental that rely on find_package and only if GMP, etc. are in a non-default prefix. So probably all Travis tests will be fine if prereqs are installed via apt-get (i.e. to /usr). Our TA Travis tests were also fine; I only had issues on my Mac where Brew installs GMP & co to /usr/local, and Apple's clang does not look there by default.

evaleev added a commit to ValeevGroup/tiledarray that referenced this pull request Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants