Merged
Conversation
export El dependency on GMP, MPFR, MPC, QG, and Valgrind include dirs
Parallelizing copy and zero routines with OpenMP.
Faster multithreaded algorithm for Copy and Zero.
…f order when threaded
Buffer printing for whole matrices
Conflicts: CMakeLists.txt src/io/Print.cpp
benson31
requested changes
Feb 12, 2018
Collaborator
benson31
left a comment
benson31
left a comment
There was a problem hiding this comment.
Famous last words: Looks fine to me!
benson31
approved these changes
Feb 12, 2018
Collaborator
|
I didn't mean to request changes, I'm just bad at clicking buttons. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary reason for this pull request is get functionality from elemental#251 (OpenMP parallelization of Copy and Zero routines).
@benson31 Several CMake changes from elemental#249 are wiped out by your changes to CMakeLists.txt. I'm not sure whether it's best to completely wipe out that PR, to replicate its functionality, or leave it as is.