Animate screenshot background while loading#1051
Merged
danirabbit merged 3 commits intomasterfrom Jul 29, 2019
Merged
Conversation
cassidyjames
commented
Jul 27, 2019
|
|
||
| @keyframes loading { | ||
| from { | ||
| background-position: -600px center; |
Contributor
Author
There was a problem hiding this comment.
I tried with percentages and it seems GTK didn't like that.
Contributor
Author
|
Video of the effect: https://youtu.be/FNpZU_eaA10. The hiccup in the video is because this is on a lower-end desktop doing too much in the background. Whoops. |
danirabbit
reviewed
Jul 29, 2019
Co-Authored-By: Daniel Foré <daniel@elementary.io>
danirabbit
approved these changes
Jul 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #1050, using the sort of shine placeholder animation that's become common on the web and in apps like Slack. If we think it's clear enough that it's loading, we could even remove the spinner altogether.