Skip to content

arrow.css: Don't hardcode arrow color#1240

Merged
cassidyjames merged 2 commits into
masterfrom
fix-dark-arrows
Mar 31, 2020
Merged

arrow.css: Don't hardcode arrow color#1240
cassidyjames merged 2 commits into
masterfrom
fix-dark-arrows

Conversation

@cassidyjames
Copy link
Copy Markdown
Contributor

Instead, use @textColorPrimary so it remains contrasty with the @base_color. Fixes unreadable arrows when using a dark style.

Instead, use `@textColorPrimary` so it remains contrasty with the `@base_color`. Fixes unreadable arrows when using a dark style.
@cassidyjames cassidyjames added the Good First Issue Should be solvable in a day or less by someone new label Mar 31, 2020
@cassidyjames cassidyjames requested a review from danirabbit March 31, 2020 18:12
Copy link
Copy Markdown
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment

Comment thread data/styles/arrow.css Outdated
Copy link
Copy Markdown
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment

Copy link
Copy Markdown
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment

Co-Authored-By: Daniel Foré <daniel@elementary.io>
@cassidyjames cassidyjames requested a review from danirabbit March 31, 2020 18:22
@cassidyjames cassidyjames merged commit 3d7c9be into master Mar 31, 2020
@cassidyjames cassidyjames deleted the fix-dark-arrows branch March 31, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First Issue Should be solvable in a day or less by someone new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants