Conversation
cassidyjames
commented
Jul 30, 2018
Contributor
Author
|
This is going to become more important with #971, as Flatpaks do often have this format for proprietary licenses. An example (of many) is VS Code. |
Contributor
Author
|
@donadigo and I chatted briefly. We'd really prefer the expected strings here be in the AppStream spec, as the linked issue mentions. For now, however, we can echo what GNOME Software does and ship the strings in AppCenter along with their translated strings. |
jeremypw
reviewed
Apr 15, 2019
jeremypw
reviewed
Apr 15, 2019
jeremypw
reviewed
Apr 15, 2019
jeremypw
reviewed
Apr 15, 2019
jeremypw
reviewed
Apr 15, 2019
src/Views/AppInfoView.vala
Outdated
| case "public-domain": | ||
| // TRANSLATORS: See the Wikipedia page | ||
| license_copy = _("Public Domain"); | ||
| if (license_url != null) { |
Contributor
There was a problem hiding this comment.
Do you mean to overwrite the url given in the project license?
Contributor
Author
There was a problem hiding this comment.
Oops, I think this was intended to be == null
jeremypw
requested changes
Apr 15, 2019
Contributor
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
Some comments in the code, but seems to work OK using some dummy project_license strings.
jeremypw
approved these changes
Apr 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial terribleLicenseRef-proprietary=urlsupportAs reported at pop-os#72 and being discussed at ximion/appstream#107
Please send help 😜