GTK 4: Fix missing player controls - #331
Merged
Merged
Conversation
danirabbit
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix TODO in #295
This line has been here quite for a long time—since 27a982a (
src/Widgets/PlayerList.valawas namedsrc/Widgets/MprisWidget.valaat that time), where Bluetooth device support seems to be added. However, this has never been worked as expected in GTK 3, sinceshow_all ()is called againstdefault_widget(which shows the player controls in the above screenshot) here:https://github.com/elementary/wingpanel-indicator-sound/blob/16fb7bf5518f117bde433db92a0b8cb01fadb32f/src/Widgets/PlayerList.vala#L94
Now,
Gtk.Widget.show_all ()has gone in GTK 4, and thus this line now works as expected, i.e. make the entire PlayerList widget invisible iforg.bluezDBus service is not active for a reason like your device does not have a Bluetooth dongle.The PlayerList widget shows player controls not only for Bluetooth devices, which ObjectManager handles, but also for MPRIS players. So, I removed this line since its' strange to make the entire widget invisible if no Bluetooth device is available.