Skip to content

Remove gala-daemon#71

Merged
bobby285271 merged 3 commits into
masterfrom
leolost/rm-gala-daemon
Mar 19, 2024
Merged

Remove gala-daemon#71
bobby285271 merged 3 commits into
masterfrom
leolost/rm-gala-daemon

Conversation

@leolost2605

@leolost2605 leolost2605 commented Feb 29, 2024

Copy link
Copy Markdown
Member

I'm not 100% sure whether this is correct but since gala daemon is now started by gala I don't think it belongs in the required components in session settings?

@leolost2605 leolost2605 requested a review from a team February 29, 2024 11:44
@bobby285271

Copy link
Copy Markdown
Member

This PR is actually necessary for me to start Pantheon on NixOS after elementary/gala@351722c, otherwise gnome-session complains gnome-session-binary[1377]: WARNING: Unable to find required component 'gala-daemon'

It sounds like in gnome-session handle_required_components reads the key file, iterates RequiredComponents and invokes gsm_util_find_desktop_file_for_app_name to search the desktop files in gsm_util_get_desktop_dirs (including autostart dirs and applications dirs). So when elementary/gala@351722c removes the desktop file it makes sense to me to experience startup issues.

Though this PR also replaces gala-wayland with gala in pantheon-wayland.session's RequiredComponents, I didn't actually test the wayland session and it is unclear for me why this is needed...

@leolost2605

Copy link
Copy Markdown
Member Author

Though this PR also replaces gala-wayland with gala in pantheon-wayland.session's RequiredComponents, I didn't actually test the wayland session and it is unclear for me why this is needed...

Tbh I'm not sure why I did this either so I reverted it😅

@bobby285271 bobby285271 merged commit ea1f57e into master Mar 19, 2024
@bobby285271 bobby285271 deleted the leolost/rm-gala-daemon branch March 19, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants