Skip to content

Conversation

@srprkr
Copy link

@srprkr srprkr commented Oct 24, 2019

Required for #2193

Changes Summary

  • Changes buttons/input box shadows for better support in dark mode.
  • Removes unused .dark class selectors in css files and nests corresponding rules in a prefers-color-scheme:dark media query to activate those intended styles
  • Dims placeholder text of custom donation box when selected.

This pull request is ready for review.

@srprkr srprkr mentioned this pull request Oct 24, 2019
6 tasks
@lewisgoddard lewisgoddard added the Has: Conflicts Pull Request has file conflicts that need to be resolved. label Oct 24, 2019
@srprkr
Copy link
Author

srprkr commented Oct 24, 2019

I removed the conflicts. I just opted for what came from master since that was code I didn't touch in my changes. Let me know if that was wrong.

@lewisgoddard lewisgoddard removed the Has: Conflicts Pull Request has file conflicts that need to be resolved. label Oct 24, 2019
@srprkr srprkr force-pushed the dark_theme_buttons branch from a09ca1f to 27d3dc9 Compare October 25, 2019 01:26
@srprkr
Copy link
Author

srprkr commented Oct 25, 2019

Sorry for the messiness. I have the stylelint issues fixed now.

@lewisgoddard lewisgoddard requested a review from cassidyjames May 6, 2020 17:04
@lewisgoddard lewisgoddard changed the base branch from master to prefer-dark May 7, 2020 22:05
@lewisgoddard lewisgoddard changed the base branch from prefer-dark to master May 7, 2020 22:07
@lewisgoddard lewisgoddard added Has: Conflicts Pull Request has file conflicts that need to be resolved. Status: Blocked Status: Incomplete labels Aug 27, 2021
@lewisgoddard lewisgoddard mentioned this pull request Oct 11, 2021
3 tasks
@lewisgoddard lewisgoddard requested review from a team and removed request for cassidyjames July 12, 2022 23:48
@RMcNeely
Copy link
Contributor

RMcNeely commented Oct 4, 2022

Hi Sean, we're in the process of closing stale branches if you're still interested feel free to reopen and resolve the conflicts

@RMcNeely RMcNeely closed this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Has: Conflicts Pull Request has file conflicts that need to be resolved. Status: Incomplete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants