Filter for generated CSS file names

[swiderski]

I have mulitisite installation, with unified upload directory – it means files from all sites land in one place, not in per site directory. It is done so we save lot of space with our demo data. No matter.

Now Elementor is creating 2 types CSS files

1. global.css
2. post-10834.css(1 for each post)

However cause my multisite is using same upload directory these files are overwriting each other on different sites.

I managed to solve this(by editing plugin code) by adding blog id to file names that are generated per post and to global.css, so they look now like this:

1. global-85.css
2. post-85-10834.css

Now I have question:

Could you add filters to Post_CSS_File::get_file_name() & Global_CSS_File::get_name() ? I know this is not standard situation, but thanks to it I wouldn’t have to edit plugin every time to make it work with my setup for demo sites.

Maybe you have other proposition what I could “filter” to achieve similar effect of unique file names?

I looked for way to overwrite this without editing plugin, but there are no such filters that would suit this situation.

I could change file name of embeded CSS files on elementor/global-css-file/enqueue & elementor/post-css-file/enqueue` actions, but still there is problem with file names "on save".

With kind regards.
Air.

[bainternet]

@swiderski

How is your multisite setup with a unified upload directory? via a plugin? code? hack?

[swiderski]

Hey there!

I don't use hacks, only filters. Filter is added into our personal plugin.

/*
 * It changes paths for uploads for sites in multi-site. All files land in same folder, not in sub-folders for sites.
 * So instead rifetheme.com/wp-content/uploads/sites/17/ it returns rifetheme.com/wp-content/uploads/
 */
	function a13_all_uploads_in_one_place( $dirs ) {
		$dirs['baseurl'] = network_site_url( '/wp-content/uploads' );
		$dirs['basedir'] = ABSPATH . 'wp-content/uploads';
		$dirs['path'] = $dirs['basedir'] . $dirs['subdir'];
		$dirs['url'] = $dirs['baseurl'] . $dirs['subdir'];

		return $dirs;
	}
add_filter( 'upload_dir', 'a13_all_uploads_in_one_place' );

Does it matter for the case?

[swiderski]

Just un update, how I currently solve this.

Currently, I am stuck with my modifications of Elementor in version 1.9.x

plugins/elementor/includes/css-file/post-css-file.php

    protected function get_file_name() {
        return 'global'.'-'.get_current_blog_id();
    }

plugins/elementor/includes/css-file/global-css-file.php

    protected function get_file_name() {
        return self::FILE_PREFIX.get_current_blog_id().'-' . $this->post_id;
    }

Above 2 changes are for adding blog-id to CSS files

Below change is to protect deleting CSS files on various Elementor actions - your sites end up then as an unstyled mess - not the best situation in case of hundreds of sites build on Elementor...

plugins\elementor\includes\managers\css-files.php

    public function clear_cache() {
        $errors = [];

        // Delete post meta.
        global $wpdb;

        $wpdb->delete(
            $wpdb->postmeta, [
                'meta_key' => Post_CSS_File::META_KEY,
            ]
        );

        $wpdb->delete(
            $wpdb->options, [
                'option_name' => Global_CSS_File::META_KEY,
            ]
        );

        return $errors; //here is EDIT

        // Delete files.
        $wp_upload_dir = wp_upload_dir( null, false );

        $path = sprintf( '%s%s%s*', $wp_upload_dir['basedir'], CSS_File::FILE_BASE_DIR, '/' );

        foreach ( glob( $path ) as $file ) {
            $deleted = unlink( $file );

            if ( ! $deleted ) {
                $errors['files'] = 'Cannot delete files cache';
            }
        }

        return $errors;
    }

Hope this helps you or someone will take into account adding filters/actions for these stuff.

In case of last change: It would be nice if Elementor would check if requested CSS file exists and regenerate it if missing. Not much overhead, but saves so many lives!

[bainternet]

@swiderski

We see the value in the particular enhancement being suggested but have decided for now not to prioritize it. If you, however, decide to write a patch for it, we'll gladly include it after some code review.

thanks.