Skip to content

Internal: Update Elementor One test screenshots for WordPress 7 [ED-23303]#35088

Merged
hein-obox merged 6 commits intomainfrom
internal/ED-23303-editor-one-test
Mar 12, 2026
Merged

Internal: Update Elementor One test screenshots for WordPress 7 [ED-23303]#35088
hein-obox merged 6 commits intomainfrom
internal/ED-23303-editor-one-test

Conversation

@hein-obox
Copy link
Copy Markdown
Member

@hein-obox hein-obox commented Mar 12, 2026

✨ PR Description

Purpose: Update Playwright test infrastructure to support WordPress 7 screenshot variants and enable nightly build testing for Elementor home screen UI tests.

Main changes:

  • Added dynamic screenshot naming helper to differentiate WordPress 7 test snapshots from standard versions
  • Extended GitHub Actions workflow with run_mode parameter to trigger nightly WordPress builds on-demand
  • Refactored home screen tests to use dynamic screenshot names based on WordPress version detection

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how

@github-actions
Copy link
Copy Markdown
Contributor

Review Summary

Overall: Clean implementation for WordPress 7 screenshot support

Issues Found (2)

  1. 🚨 Edge Case: Missing validation for filenames without extensions - see inline comment
  2. 📝 Code Pattern: Magic strings should be extracted to constants - see inline comment

Observations

  • ✨ Good approach using dynamic screenshot naming based on WordPress version
  • 🔄 Consider: This hardcoded approach may need refactoring when WordPress 8+ is released (future scalability concern)

@github-actions github-actions bot added the auto-reviewed PR has been automatically reviewed by CI label Mar 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Review Summary

Overall: Clean approach to handling WordPress 7 screenshot variants

Issues Found (2)

  1. 🚨 Critical - Edge case bug with lastIndexOf when no file extension exists
  2. Improvement - Extract magic string selector to constant for maintainability

Optional Suggestions

  • Consider adding unit tests for getScreenshotName function to cover WordPress 7 detection and filename transformation logic
  • The repeated DOM query across tests is acceptable for test code - no optimization needed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 12, 2026

Elementor Build

Last updated at: 20260312.1119
Version: 4.1.0-20260312.1119

✅ Elementor build is ready for download.

You can download the latest build from the link below:

🔗 elementor-4.1.0-20260312.1119.zip

The build is available for 3 days.

@hein-obox hein-obox enabled auto-merge (squash) March 12, 2026 10:52
@hein-obox hein-obox merged commit a7d73b9 into main Mar 12, 2026
80 checks passed
@hein-obox hein-obox deleted the internal/ED-23303-editor-one-test branch March 12, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 min review auto-reviewed PR has been automatically reviewed by CI cp_4.00

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants