Skip to content

Fix: Wrapping div has height despite no content shown. [ED-24996] - #675

Merged
Ntnelbaba merged 1 commit into
mainfrom
ED-24996
Jul 23, 2026
Merged

Fix: Wrapping div has height despite no content shown. [ED-24996]#675
Ntnelbaba merged 1 commit into
mainfrom
ED-24996

Conversation

@RobiFerentz

@RobiFerentz RobiFerentz commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

✨ PR Description

1. Problem & Context

Wrapping Box component was causing unwanted height on the banner container. Moved spacing logic directly to Welcome component via sx prop to eliminate the outer wrapper.

2. What Changed (Where)

  • hello-elementor-conversion-banner.js: Removed Box wrapper; consolidated pt/pr/pb spacing into mt/mr/mb on Welcome component with width: 100% applied directly.

3. How It Works

Welcome now manages its own spacing through margin and padding props instead of relying on parent Box for layout. No structural change—purely shifting responsibility for spacing down one level.

4. Risks

None. DOM structure simplified; behavior identical since Welcome applies the same spacing values.

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Ntnelbaba
Ntnelbaba merged commit 0e503e4 into main Jul 23, 2026
22 of 23 checks passed
@Ntnelbaba
Ntnelbaba deleted the ED-24996 branch July 23, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants