Internal: Unblock PHPUnit composer install from security advisories [TMZ-1064] - #679
Merged
Merged
Conversation
…TMZ-1064] The PHPUnit workflow runs composer update, which refuses to resolve wp-coding-standards/wpcs 3.3.0 because of CVE-2026-45293. Bump to 3.4.1, the first unaffected release. Also refresh squizlabs/php_codesniffer to 3.13.6 in the lock file so it no longer ships the version affected by CVE-2026-67434. Ref: TMZ-1064 Co-authored-by: Netanel Baba <Ntnelbaba@users.noreply.github.com>
|
|
Ntnelbaba
marked this pull request as ready for review
August 6, 2026 13:48
Ntnelbaba
enabled auto-merge (squash)
August 6, 2026 13:49
davseve
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All 20 PHPUnit jobs are failing on
main, not just on open PRs. The failure is in the Install Dependencies step, before any test runs.Root cause
phpunit.ymlrunscomposer update, which re-resolves dependencies.composer.jsonpinswp-coding-standards/wpcsto exactly3.3.0, and that version is covered by CVE-2026-45293 (advisoryPKSA-mh9b-91zm-m1gy, affects>=0.14.1,<3.4.1, reported 2026-07-27). Composer refuses to install packages under an advisory, and because the pin is exact there is no alternative to fall back to:The Lint workflow stayed green because it runs
composer installfrom the existing lock file, which does not re-resolve.Changes
wp-coding-standards/wpcsto3.4.1, the first release outside the advisory rangesquizlabs/php_codesnifferto3.13.6in the lock.composer auditflagged the locked3.13.5for CVE-2026-67434 (reported 2026-08-05); the^3.6constraint already allowed the fixed version, so only the lock needed updatingTesting
Reproduced the original failure locally, then after the fix:
composer update --no-interaction(the exact PHPUnit workflow command) resolves successfullycomposer auditreports no advisoriescomposer run lint:php(PHPCS) passes clean, so the wpcs minor bump introduces no new sniff violationsJira
TMZ-1064