fix: resolve CI lint and typecheck failures#72
Merged
Conversation
- Fix TypeScript error in optional catch-all route by marking slug as optional - Upgrade eslint-config-next from 15.x to 16.x for Next.js 16 compatibility - Replace broken `next lint` command with direct `eslint` invocation - Rewrite eslint.config.mjs to use native flat config (drop FlatCompat) - Remove unused @eslint/eslintrc and @typescript-eslint/parser deps Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
Been waiting for review for some time and this seems safe to merge 👍 Please review in retrospect if that's not the case. |
Collaborator
|
Looks great sir, appreciate this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[[...slug]]optional catch-all route inapp/(app)/llm/[[...slug]]/route.tstypedslugasstring[]but it can beundefined— fixed by marking it optional (slug?: string[])next lint: Next.js 16 removed thenext lintcommand. Updated the lint script to useeslint .directlyeslint-config-nextfrom 15.x to 16.x (matching Next.js 16) and rewroteeslint.config.mjsto use native flat config instead of theFlatCompatwrapper. New react-hooks v7 rules are disabled until the codebase is ready to adopt them (tracked in Enable new react-hooks v7 lint rules and lint scripts directory #73)@eslint/eslintrcand@typescript-eslint/parserdev dependenciesTest plan
pnpm typecheckpasses (0 errors)pnpm lintpasses (0 errors, warnings only)pnpm format:checkpasses🤖 Generated with Claude Code