Skip to content

fix: resolve wheel build collisions by refining package paths - #654

Merged
BenjPetr merged 1 commit into
mainfrom
fix/resolve_wheel_build_collision
Jul 29, 2026
Merged

fix: resolve wheel build collisions by refining package paths#654
BenjPetr merged 1 commit into
mainfrom
fix/resolve_wheel_build_collision

Conversation

@BenjPetr

@BenjPetr BenjPetr commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Signed-off-by: Benjamin Petrick 170433522+BenjPetr@users.noreply.github.com

Checklist

Please check if the PR fulfills these requirements:

  • PR Title follows conventional commit messages
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • All commits in this PR are DCO signed-off (see CONTRIBUTING.md)

Does this PR already have an issue describing the problem?

No

What is the new behavior (if this is a feature change)?

This PR corrects the pyproject.toml configuration to prevent build failures during wheel creation. It explicitly maps each sub-package to its specific source directory instead of the generic src parent folders.

Changes:

Fixed Build Failure: Resolved a ValueError where multiple src/init.py files were colliding in the wheel archive.
Improved Distribution: Restricted the bundled files to only the intended toop_engine_* packages, automatically excluding auxiliary scripts (like compile_proto.sh) and boilerplate files located in the src roots.
Backend Optimization: Standardized the Hatch build target configuration to ensure reliable installations across all modules.

Does this PR introduce a breaking change?

  • Yes
  • No

Signed-off-by: Benjamin Petrick <170433522+BenjPetr@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 29, 2026 12:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the root Hatch wheel-build configuration to avoid file collisions during monorepo wheel creation by scoping the wheel’s included packages to the concrete toop_engine_* package directories (instead of each package’s generic src/ root).

Changes:

  • Refines [tool.hatch.build.targets.wheel].packages to point at packages/*_pkg/src/toop_engine_* directories explicitly.
  • Prevents accidental inclusion of non-package root files (e.g., src/__init__.py, helper scripts) that can collide or be unintentionally bundled.

@BenjPetr
BenjPetr enabled auto-merge (squash) July 29, 2026 12:33
@sonarqube-mccs

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@BenjPetr
BenjPetr merged commit 2ad64ee into main Jul 29, 2026
23 checks passed
@BenjPetr
BenjPetr deleted the fix/resolve_wheel_build_collision branch July 29, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants