Add same-format round-trip integration tests - #77
Open
elicwhite wants to merge 1 commit into
Open
Conversation
This was referenced Apr 20, 2026
Owner
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 20, 2026
elicwhite
force-pushed
the
midi-writer-vocals
branch
from
April 20, 2026 05:09
17b2b16 to
ba58fa3
Compare
elicwhite
force-pushed
the
round-trip-integration
branch
from
April 20, 2026 05:09
9104edd to
139de95
Compare
elicwhite
force-pushed
the
midi-writer-vocals
branch
from
April 20, 2026 05:10
ba58fa3 to
cc46d30
Compare
elicwhite
force-pushed
the
round-trip-integration
branch
2 times, most recently
from
April 20, 2026 05:19
5c8ed73 to
da67ddc
Compare
This was referenced Apr 20, 2026
elicwhite
marked this pull request as ready for review
April 20, 2026 16:09
elicwhite
force-pushed
the
midi-writer-vocals
branch
from
April 21, 2026 04:29
631a9d0 to
a5b46ec
Compare
elicwhite
force-pushed
the
round-trip-integration
branch
from
April 21, 2026 04:29
da67ddc to
8d80779
Compare
elicwhite
force-pushed
the
midi-writer-vocals
branch
from
April 21, 2026 04:47
a5b46ec to
e69e3e0
Compare
elicwhite
force-pushed
the
round-trip-integration
branch
from
April 21, 2026 04:48
8d80779 to
d20ac10
Compare
elicwhite
force-pushed
the
midi-writer-vocals
branch
from
April 21, 2026 05:06
e69e3e0 to
b5242da
Compare
elicwhite
force-pushed
the
round-trip-integration
branch
from
April 21, 2026 05:06
d20ac10 to
adf91a9
Compare
elicwhite
force-pushed
the
midi-writer-vocals
branch
from
April 21, 2026 16:35
b5242da to
7a8a4ff
Compare
elicwhite
force-pushed
the
round-trip-integration
branch
from
April 21, 2026 16:35
adf91a9 to
48c5edf
Compare
elicwhite
force-pushed
the
midi-writer-vocals
branch
from
April 21, 2026 16:38
7a8a4ff to
09e9e4e
Compare
elicwhite
force-pushed
the
round-trip-integration
branch
from
April 21, 2026 16:38
48c5edf to
079b471
Compare
elicwhite
force-pushed
the
midi-writer-vocals
branch
from
April 21, 2026 16:51
09e9e4e to
4de2741
Compare
elicwhite
force-pushed
the
round-trip-integration
branch
from
April 21, 2026 16:51
079b471 to
1e055a2
Compare
elicwhite
force-pushed
the
round-trip-integration
branch
from
April 21, 2026 23:18
1e055a2 to
f3dfd0d
Compare
elicwhite
force-pushed
the
midi-writer-vocals
branch
from
April 21, 2026 23:18
4de2741 to
771cfa8
Compare
End-to-end coverage for the scan-chart writers: build a ParsedChart,
serialize via writeChartFile/writeMidiFile, re-parse via parseChartAndIni,
and assert that structured fields survive.
The per-feature tests (chart-writer.test.ts, midi-writer.test.ts) already
cover granular correctness. This file's job is interactions across tracks
— e.g. a chart with drums + guitar + vocals populated together — and the
"everything enabled at once" shape the earlier tests skip.
Coverage:
- tempo/TS/sections/endEvents (both formats)
- drums: kick, tom/cymbal, accent, ghost, 2x-kick (both formats)
flam: .mid only (the .chart parser doesn't recognize N 109 — writer
emits it, parser gap is pre-existing)
- 5-fret: base colors + forceHopo + forceTap + sustains (both formats)
star power + solo sections (both formats)
- GHL: open + chord-with-open ENHANCED_OPENS path (both formats)
- vocals: PART VOCALS full shape; HARM1/2/3 with CopyDown semantics (.mid)
- multi-track: drums + guitar + bass (both formats); drums + guitar +
vocals (.mid)
- metadata: [Song] fields and chart_offset via .chart
18 new tests; 433 total passing.
elicwhite
force-pushed
the
round-trip-integration
branch
from
April 22, 2026 16:34
f3dfd0d to
6862111
Compare
elicwhite
force-pushed
the
midi-writer-vocals
branch
from
April 22, 2026 16:34
771cfa8 to
53a5a9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
End-to-end coverage for the scan-chart writers: build a ParsedChart,
serialize via writeChartFile/writeMidiFile, re-parse via parseChartAndIni,
and assert that structured fields survive.
The per-feature tests (chart-writer.test.ts, midi-writer.test.ts) already
cover granular correctness. This file's job is interactions across tracks
— e.g. a chart with drums + guitar + vocals populated together — and the
"everything enabled at once" shape the earlier tests skip.
Coverage:
flam: .mid only (the .chart parser doesn't recognize N 109 — writer
emits it, parser gap is pre-existing)
star power + solo sections (both formats)
vocals (.mid)
18 new tests; 433 total passing.