fix(release): build @book.dev/mcp before the desktop sidecar so bun can resolve it#152
Merged
Merged
Conversation
…an resolve it Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KFk2T9k3p7ghCjdzMfkA5w
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The v2.1.0 desktop Release fails on all three platforms (macOS/Windows/Linux) at "Build Tauri bundles":
during
bun build packages/server/src/bin.bun.ts --compile(the sidecar compile).Root cause
AGENT-5 (#150) made
packages/serverdepend on@book.dev/mcp(app.ts→mcpHttp.tsimportscreateOpenBookMcpServer). Bun--compileresolves that workspace package via itsmain: dist/index.js. Rootpackage.jsonbuild:libswas updated to build mcp in order (sdk → ui → mcp → server), but the TauribeforeBuildCommandintauri.conf.jsonstill hand-listed onlysdk → ui → server:sidecar, so mcp was never built before the compile.@book.dev/serveris only a devDependency of@book.dev/mcpand nothing inpackages/mcp/srcimports it, so mcp builds cleanly before the sidecar (the cycle is test-only).Fix
tauri.conf.jsonbeforeBuildCommand: build@book.dev/mcpbeforebuild:sidecar(parity withbuild:libs).packages/server/scripts/build-sidecar.mjs: on-demand build@book.dev/mcpif itsdist/index.jsis missing (mirrors the existing viewer-bundle on-demand build) so a standalonebuild:sidecaris self-sufficient.Verification (reproduced the real
bun --compile— mocked tests hid the original break)Could not resolve "@book.dev/mcp"failure withpackages/mcp/distabsent.pnpm --filter @book.dev/server run build:sidecarsucceeds — logs@book.dev/mcp dist missing — building it…, builds mcp, compiles the sidecar →openbook-server-aarch64-apple-darwin, 83.8 MB,Mach-O 64-bit executable arm64.rm -rf packages/mcp/distthen re-run: on-demand rebuild works, binary re-produced.--helpruns (exit 0).Board: AGENT-8 (under the Agent epic).
🤖 Generated with Claude Code