fix(ui): curve dependency arrows + paint desktop cover tint behind the titlebar glass#154
Merged
Merged
Conversation
…ing elbows Replace the orthogonal elbow dependency connector with a smooth cubic Bézier that has horizontal end tangents. The old `H midX V y2 H x2` path drew ugly right-angle corners, and for backward dependencies (successor starts before the predecessor ends, x2 < x1) `midX` clamped to x1+8, so the path juts right then doubles back left as a square self-hook. The Bézier leaves the predecessor's end going right and enters the successor's start going right, so the backward case reads as a clean loop. Arrowhead (markerEnd, orient=auto) still enters the bar horizontally; stroke class/width unchanged; unused midX removed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KFk2T9k3p7ghCjdzMfkA5w
…hite leak) On the macOS desktop app the window is overlay-titlebar + hidden title, so the WKWebView content extends under the titlebar / traffic-lights. The white `body` (`--background`) then leaked behind that glass and at the window edges, breaking the continuous notebook-cover feel. Paint the app root with the cover tint (`--sheet-1`, the same value `.ob-desk` uses) so any region not covered by a page sheet shows the cover tint instead of white. Scoped to the desktop in-window-titlebar shell via `data-titlebar` on `.ob-app-root` (set by DefaultLayout); the web root stays transparent so the web framing is unchanged. Tracks --sheet-1 exactly, verified in both light and dark. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KFk2T9k3p7ghCjdzMfkA5w
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small owner-reported UI-polish fixes.
1. Database dependency arrows — square, self-looping elbows → smooth curves
packages/ui/src/components/database/databaseTimeline.tsx. The dependency edge drew an orthogonal elbowM x1 y1 H midX V y2 H x2withmidX = Math.max(x1+8, x2-8)— square corners, and when the successor starts before the predecessor ends (x2 < x1) it juts right then doubles back left (an ugly self-hook).Now a cubic Bézier with horizontal end tangents:
The backward case reads as a clean curve instead of a square double-back. Arrowhead marker/
orient="auto"unchanged — the endpoint tangent stays horizontal, so it still points cleanly into the successor's start.2. Desktop cover tint behind the titlebar glass — no white leak
.ob-desk(the book cover) paints the sidebar tint--sheet-1, butbodypaints white--background. On the macOS desktop app (titleBarStyle: Overlay+hiddenTitle), WKWebView content extends under the titlebar, so the white leaked behind the traffic-light "glass" and at window edges — breaking the continuous notebook-cover feel.Fix: the 100vh app root (
DefaultLayout.tsx) gets.ob-app-root+ the existingdata-titlebardesktop signal, and:Scoped to the desktop shell (web leaves the attr unset → root stays transparent, framed-sheets look unchanged). Value tracks
--sheet-1so it runs continuously into.ob-desk.Verification
database-timeline.spec.ts) — 10/10 pass, incl. all 3 dependency specs (link, drag-to-link, dependency graph).@book.dev/uibuild +tsc --noEmitclean.style.css:.ob-app-root[data-titlebar]background ==.ob-deskexactly — lightrgb(250,249,248), darkrgb(40,40,40); web root transparent.Board: two "Editor & UX" polish issues.
🤖 Generated with Claude Code