Windows host: prefer .bat and hidden console for OTP 26 - #8
Merged
Conversation
CreateProcess must not run the Mix release shell script (error 193). OTP 26 also needs a real console for user/logger; spawn with a hidden CREATE_NEW_CONSOLE instead of sharing invalid or NUL stdio handles. Co-authored-by: Cursor <cursoragent@cursor.com>
Build DesktopWebView as a WIN32 (wWinMain) app so packaged installs do not open a console. Resolve config as <exe_basename>.ini first so renamed hosts such as dDrive.exe still load dDrive.ini. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/*.batwhen spawning BEAM (avoids Windows error 193 on the extensionless shell script).CREATE_NEW_CONSOLEso OTP 26user/loggerget a real console (NUL/invalid handles causednouser/ crash loops).wWinMain) so the packaged process never shows a terminal.<exe_basename>.inifirst (e.g.dDrive.inifordDrive.exe), thenDesktopWebView.ini.Test plan
scripts/build_windows.ps1(PE subsystem = GUI)