No longer raise if logging raises - #86
Merged
Merged
Conversation
fishcakez
commented
Jul 3, 2017
| catch | ||
| kind, reason -> | ||
| stack = System.stacktrace() | ||
| {kind, reason, stack, meter} |
Member
Author
There was a problem hiding this comment.
Now long poolboy time outs
| meter = event(meter, :checkout) | ||
| with {:ok, conn, conn_info, meter} <- checkout(pool, meter, opts) do | ||
| try do | ||
| fun.(conn, conn_info, arg, meter, opts) |
Member
Author
There was a problem hiding this comment.
All "connection time" runs inside this fun (or similar, above/below), which could be instrumented using fun based instrumentation.
| end | ||
| defp run_begin(conn, conn_info, meter, opts) do | ||
| meter = event(meter, :begin) | ||
| handle_trans(conn, conn_info, :handle_begin, meter, opts, :transaction) |
Member
Author
There was a problem hiding this comment.
Transaction calls aren't wrapped in run calls with funs but could be as parameters align.
| defp event(nil, _), | ||
| do: nil | ||
| defp event({log, events}, event), | ||
| do: {log, [{event, :erlang.monotonic_time()} | events]} |
Member
Author
There was a problem hiding this comment.
simple stack based/pure implementation so could wrap any stateful instrumenter
josevalim
approved these changes
Jul 4, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit changes the behaviour and the second commit does a substantial refactor to help with #82 and any future metrics work. Hopefully this will pave the way for future integration with any standard instrumentation lib. This PR uses a stateful approach because it fits well with multiple timestampings. However all "connection_time" work is carried out inside a closure except begin/commit/rollback.