Fix splice params in dynamic expressions#4750
Merged
Merged
Conversation
lukaszsamson
force-pushed
the
ls-splice-duplication
branch
from
6488eea to
96c27b7
Compare
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does 2 changes
expand/4to recurese accumulating splices into a map. Previously the postwalk appended the shared {list, {:splice, :any}} param once per placeholder occurrence resulting in k placeholders x k copies of params and mis-bound placeholders. Now the first occurrence appends the param, so the following ones can reuse itlength(unquote(params))intounquote(length(params))as params is a plain compile-time listFixes #4748