Fix subqueries in interpolated join wheres#4764
Draft
lukaszsamson wants to merge 3 commits into
Draft
Conversation
josevalim
reviewed
Jul 24, 2026
| defmodule QueryExpr do | ||
| @moduledoc false | ||
| defstruct [:expr, :file, :line, params: []] | ||
| defstruct [:expr, :file, :line, params: [], subqueries: []] |
Member
There was a problem hiding this comment.
Can we instead use a BooleanExpr or add subqueries to the JoinExpr?
Contributor
Author
There was a problem hiding this comment.
I can try that
Contributor
Author
There was a problem hiding this comment.
@josevalim I had fable create an alternative basing on your suggestion #4765
Note the JoinExpr.subqueries alternative would be more problematic as it requires threading context through traversals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4763