fix: refresh error spam on direct_state (no lb) #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleipnir
approved these changes
Oct 28, 2025
Collaborator
|
@JoeriDijkstra please format and send again |
Contributor
Author
|
@sleipnir I reformatted it, maybe smart to add it as a pre-commit hook |
Collaborator
Ok. Thank you, good suggestion! |
Collaborator
|
Thank you for your contribution @JoeriDijkstra |
|
Hello, was just curious when this fix will be released? Also, thank you for fixing it! |
Collaborator
|
You're welcome @StephenTurley. |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some context - even with the direct state where no lb_mod is picked the refresh is sent. This causes the lb_mod.pick on line 277 to crash, even though we don't use any loadbalancing