Skip to content

fix: refresh error spam on direct_state (no lb) #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2025
Merged

fix: refresh error spam on direct_state (no lb) #456

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cdae9f
fix: refresh error spam on direct_state (no lb)
Oct 28, 2025
477e84f
chore: formatting connection module
Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/grpc/client/connection.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,8 @@ defmodule GRPC.Client.Connection do
:refresh,
%{lb_mod: lb_mod, lb_state: lb_state, real_channels: channels, virtual_channel: vc} =
state
) do
)
when not is_nil(lb_mod) do
{:ok, {prefer_host, prefer_port}, new_lb_state} = lb_mod.pick(lb_state)

channel_key = "#{prefer_host}:#{prefer_port}"
Expand All @@ -294,6 +295,8 @@ defmodule GRPC.Client.Connection do
end
end

def handle_info(:refresh, state), do: {:noreply, state}

def handle_info({:DOWN, _ref, :process, pid, reason}, state) do
Logger.warning(
"#{inspect(__MODULE__)} received :DOWN from #{inspect(pid)} with reason: #{inspect(reason)}"
Expand Down
Loading