remove_metadata/2 :xmp selector is a silent no-op, maps to wrong header name

[hlindset]

Removing XMP via the :xmp field selector does nothing because the @metadata_fields map has a typo (xmp-dataa).

Reproduction

{:ok, base} = Vix.Vips.Operation.black(8, 8, bands: 3)
{:ok, img} =
  Vix.Vips.Image.mutate(base, fn m ->
    Vix.Vips.MutableImage.set(m, "xmp-data", :VipsBlob, "FAKE-XMP")
  end)
# attempt to remove XMP data by atom key
{:ok, a} = Image.remove_metadata(img, :xmp)
Vix.Vips.Image.header_field_names(a)
#=> {:ok,
 ["xmp-data", "filename", "yres", "xres", "yoffset", "xoffset",
  "interpretation", "coding", "format", "bands", "height", "width"]}   # XMP still present

Root cause

@metadata_fields %{
  exif: "exif-data",
  xmp: "xmp-dataa",   # <- should be "xmp-data"
  iptc: "iptc-data"
}

I added a test that asserts :exif/:xmp/:iptc removes their respective header, and fixed the typo in the @metadata_fields map.

[kipcole9]

Thats sloppy of me, thank you very much for the report and the PR.

[kipcole9]

I've published Image v0.68.0 with the following changelog entry:

Bug Fixes

• Fix remove_metadata/2 with :xmp selector. It was a silent no-op due to a typo in the header map. Thanks to @hlindset for the PR. Closes remove_metadata/2 :xmp selector is a silent no-op, maps to wrong header name #198.