Skip to content

remove_metadata/2 :xmp selector is a silent no-op, maps to wrong header name #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kipcole9 merged 2 commits into from
May 31, 2026
Merged

remove_metadata/2 :xmp selector is a silent no-op, maps to wrong header name #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b065465
add failing remove_metadata/2 test
hlindset May 30, 2026
1f525d6
fix xmp header name in `@metadata_fields`
hlindset May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/image.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6668,7 +6668,7 @@ defmodule Image do

@metadata_fields %{
exif: "exif-data",
xmp: "xmp-dataa",
xmp: "xmp-data",
iptc: "iptc-data"
}

Expand Down
17 changes: 17 additions & 0 deletions test/image_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,23 @@ defmodule Image.Test do
assert input_info.size > output_info.size * 2
end

test "Remove metadata", %{dir: _dir} do
image = image_path("Kip_small.jpg")
{:ok, kip} = Vimage.new_from_file(image)

for {atom_key, raw_header_key} <- [
{:exif, "exif-data"},
{:xmp, "xmp-data"},
{:iptc, "iptc-data"}
] do
{:ok, header_fields} = Vix.Vips.Image.header_field_names(kip)
assert Enum.member?(header_fields, raw_header_key)
{:ok, kip} = Image.remove_metadata(kip, [atom_key])
{:ok, header_fields} = Vix.Vips.Image.header_field_names(kip)
refute Enum.member?(header_fields, raw_header_key)
end
end

test "Circular Image", %{dir: dir} do
image = image_path("Kip_small.jpg")
{:ok, kip} = Vimage.new_from_file(image)
Expand Down