Align Access.filter/1 spec with its truthy semantics#15550
Merged
Conversation
`Access.filter/1` treats the predicate's return value as truthy/falsy, not strictly boolean: the `:get` path uses it as a comprehension filter (`for elem <- data, func.(elem)`) and the `:get_and_update` path uses `if func.(head)`. The spec `(term -> boolean)` was therefore narrower than what the code accepts. Every sibling accessor already uses `as_boolean(term)` — `Access.find/1`, `Map.filter/2`, `Keyword.filter/2`, `MapSet.filter/2` — so this aligns `Access.filter/1` with that convention. Assisted-by: Claude Code:claude-opus-4-8 Signed-off-by: nseaSeb <nseaprotector@gmail.com>
Member
|
💚 💙 💜 💛 ❤️ |
Contributor
Author
|
It makes my day, Thanks a lot @josevalim |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Access.filter/1treats the predicate's return value as truthy/falsy, not strictly boolean: the:getpath uses it as a comprehension filter (for elem <- data, func.(elem)) and the:get_and_updatepath usesif func.(head). The spec(term -> boolean)was therefore narrower than what the code accepts. Every sibling accessor already usesas_boolean(term)—Access.find/1,Map.filter/2,Keyword.filter/2,MapSet.filter/2— so this alignsAccess.filter/1with that convention.Assisted-by: Claude Code:claude-opus-4-8