Skip to content

Give helpful error message if a string is used to name a GenServer / Supervisor#5027

Merged
whatyouhide merged 2 commits into
elixir-lang:masterfrom
alecspopa:pr_helpful_msg_gen_server_supervisor
Jul 18, 2016
Merged

Give helpful error message if a string is used to name a GenServer / Supervisor#5027
whatyouhide merged 2 commits into
elixir-lang:masterfrom
alecspopa:pr_helpful_msg_gen_server_supervisor

Conversation

@alecspopa

Copy link
Copy Markdown
Contributor

Hi, this is my second PR related to #3932.
It should add helpful messages for GenServer and Supervisor.
Thanks!

@michalmuskala

Copy link
Copy Markdown
Member

I started thinking. Given in how many places we map the elixir-style process name to the erlang-style name (in standard library, and even more in 3rd party libraries), should we provide one function in the standard library to do this?

@josevalim

josevalim commented Jul 18, 2016

Copy link
Copy Markdown
Member

@michalmuskala we already do as GenServer.whereis/1. This is slightly different because we need to pass the shape "unchanged" so it is invoked later on inside the process.

@whatyouhide

Copy link
Copy Markdown
Member

Looks perfect to me! Thanks a lot @alecspopa 💟 :)

@whatyouhide whatyouhide merged commit d9cdeeb into elixir-lang:master Jul 18, 2016
@alecspopa

Copy link
Copy Markdown
Contributor Author

Thanks for merging @whatyouhide :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants