Give helpful error message if a string is used to name a GenServer / Supervisor#5027
Merged
whatyouhide merged 2 commits intoJul 18, 2016
Merged
Give helpful error message if a string is used to name a GenServer / Supervisor#5027whatyouhide merged 2 commits into
whatyouhide merged 2 commits into
Conversation
Member
|
I started thinking. Given in how many places we map the elixir-style process name to the erlang-style name (in standard library, and even more in 3rd party libraries), should we provide one function in the standard library to do this? |
Member
|
@michalmuskala we already do as |
Member
|
Looks perfect to me! Thanks a lot @alecspopa 💟 :) |
Contributor
Author
|
Thanks for merging @whatyouhide :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is my second PR related to #3932.
It should add helpful messages for GenServer and Supervisor.
Thanks!