Improve options validation in Mix.Tasks.Compile.Elixir #5470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding elixirc_options, I would validate them in the same place, even if they are used downstream. There is a chance Code.compiler_options/1 already validate them too. |
josevalim
reviewed
Nov 20, 2016
|
|
||
| defp assert_valid_elixirc_paths(paths) do | ||
| unless is_list(paths) do | ||
| Mix.raise ":elixirc_paths should be a list of paths, got: #{inspect(paths)}" |
There was a problem hiding this comment.
Should we say ":elixirc_paths in project configuration should be...."?
There was a problem hiding this comment.
I thought about that but if we get here I think users had to explicitly use :elixirc_paths so they likely know where it comes from?
There was a problem hiding this comment.
That's a good point. It will fail as soon as they set it to a wrong value, so we should be good.
|
@josevalim since I merged #5472 should we go ahead and merge this one as well? The compiler options should be covered. |
josevalim
approved these changes
Nov 21, 2016
|
❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the road to #5388.
I'm on the fence on what to do with
:elixirc_optionshere, since they're not set and changed here. Not sure where would be the best place to validate those 😕