Skip to content

Improve options validation in Mix.Tasks.Compile.Elixir #5470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2016
Merged

Improve options validation in Mix.Tasks.Compile.Elixir #5470

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec007d7
Improve options validation in Mix.Tasks.Compile.Elixir
whatyouhide Nov 20, 2016
eef35a7
Remove ausiliary function, it's not needed
whatyouhide Nov 21, 2016
20223ec
Remove test to avoid bloating
whatyouhide Nov 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/mix/lib/mix/tasks/compile.elixir.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ defmodule Mix.Tasks.Compile.Elixir do
dest = Mix.Project.compile_path(project)
srcs = project[:elixirc_paths]

unless is_list(srcs) do
Mix.raise ":elixirc_paths should be a list of paths, got: #{inspect(srcs)}"
end

manifest = manifest()
configs = Mix.Project.config_files ++ Mix.Tasks.Compile.Erlang.manifests
force = opts[:force] || Mix.Utils.stale?(configs, [manifest])
Expand Down