add traverse/1 to Stream - #6369
Closed
ckampfe wants to merge 1 commit into
Closed
Conversation
Member
|
Your implementation handles only lists and maps, and not all enumerables. A function in Stream would need to consider all enumerables but the issues is, doing so is quite hard, as you can only know if something is an enumerable or not if try to invoke the protocol in it, and that can be potentially quite expensive. So it is likely this is better implemented in your application with the constraints that make sense for your application, rather than in Elixir. In any case, thanks for the PR! |
Contributor
Author
|
Makes sense, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
Stream.traverse/1. See proposal here: https://groups.google.com/forum/#!topic/elixir-lang-core/B5e8mWsQto0