Change assert_in_delta better handle a delta of 0
#7189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if the two values that we were checking were within a given delta were equal, they would fail if the expected delta was `0`.
whatyouhide
approved these changes
Jan 9, 2018
Member
|
❤️ 💚 💙 💛 💜 |
josevalim
pushed a commit
that referenced
this pull request
Jan 9, 2018
Previously if the two values that we were checking were within a given delta were equal, they would fail if the expected delta was `0`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if the two values that we were checking were within a given
delta were equal, they would fail if the expected delta was
0.