Skip to content

Change assert_in_delta better handle a delta of 0 #7189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Jan 9, 2018
Merged

Change assert_in_delta better handle a delta of 0 #7189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/ex_unit/lib/ex_unit/assertions.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,9 +689,9 @@ defmodule ExUnit.Assertions do
message =
message ||
"Expected the difference between #{inspect(value1)} and " <>
"#{inspect(value2)} (#{inspect(diff)}) to be less than #{inspect(delta)}"
"#{inspect(value2)} (#{inspect(diff)}) to be less than or equal to #{inspect(delta)}"

assert diff < delta, message
assert diff <= delta, message
end

@doc """
Expand Down
7 changes: 6 additions & 1 deletion lib/ex_unit/test/ex_unit/assertions_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,11 +667,16 @@ defmodule ExUnit.AssertionsTest do
end
end

test "assert in delta works with equal values and a delta of zero" do
assert_in_delta(10, 10, 0)
end

test "assert in delta error" do
"This should never be tested" = assert_in_delta(10, 12, 1)
rescue
error in [ExUnit.AssertionError] ->
"Expected the difference between 10 and 12 (2) to be less than 1" = error.message
"Expected the difference between 10 and 12 (2) to be less than or equal to 1" =
error.message
end

test "assert in delta with message" do
Expand Down