fix: correctly parse parentheses around anonymous function arguments - #141
Merged
Merged
Conversation
katafrakt
force-pushed
the
fix-parent-in-fn-args
branch
from
September 3, 2026 16:54
e3a2a18 to
867a0db
Compare
katafrakt
changed the title
mhanberg
pushed a commit
that referenced
this pull request
Sep 3, 2026
🤖 I have created a release *beep* *boop* --- ## [0.4.1](v0.4.0...v0.4.1) (2026-09-03) ### Bug Fixes * correctly parse parentheses around anonymous function arguments ([#141](#141)) ([ca12cb4](ca12cb4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was found via expert-lsp/expert#877
When Spitfire parses a code where anonymous function's arguments are surrounded by parentheses, it produces a different AST than
Code.string_to_quoted. This theoretically incorrect AST was fed to Sourceror, which resulted in an error reported in the issue in Expert.