Skip to content

fix(hitl): recognize real Signal account listings#15768

Merged
lalalune merged 1 commit into
developfrom
fix/15760-signal-list-accounts
Jul 9, 2026
Merged

fix(hitl): recognize real Signal account listings#15768
lalalune merged 1 commit into
developfrom
fix/15760-signal-list-accounts

Conversation

@lalalune

@lalalune lalalune commented Jul 9, 2026

Copy link
Copy Markdown
Member

Follow-up to merged #15760 for #14797.

Reviewing the Signal linked-account change against the current upstream CLI exposed two contract mismatches:

  • dashboard availability used only listAccounts exit status, but the upstream command returns normally for an empty account collection, so an unlinked CLI could be reported ready;
  • the live probe accepted only bare +number/u:username lines, while current signal-cli plaintext output is Number: <account>, so a linked account could be reported absent.

The upstream implementation is visible in ListAccountsCommand.java.

This adds a declarative command-output-nonempty availability leaf, carries stdout through the real-machine evaluator, requires actual account-list output, and normalizes the upstream Number: prefix before validating and masking account identifiers.

Verification

  • focused registry/probe suite: 26/26 passed;
  • complete test:lifeops-hitl lane: 58/58 passed;
  • Biome passed on all four changed scripts;
  • git diff --check passed;
  • tests cover a zero-exit empty listing, current-format non-empty output, live-probe parsing, and last-four-only masking.
  • N/A - no agent action, prompt, provider, model, or trajectory behavior changed.
  • N/A - read-only account enumeration sends no Signal messages and writes no LifeOps domain records.

@claude

claude Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error —— View job


I'll analyze this and get back to you.

@lalalune lalalune force-pushed the fix/15760-signal-list-accounts branch from 0cee3cf to f1171d7 Compare July 9, 2026 21:12
@claude

claude Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error —— View job


I'll analyze this and get back to you.

@lalalune lalalune force-pushed the fix/15760-signal-list-accounts branch from f1171d7 to d9da5ea Compare July 9, 2026 21:29
@claude

claude Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error —— View job


I'll analyze this and get back to you.

@lalalune lalalune force-pushed the fix/15760-signal-list-accounts branch from d9da5ea to f09804f Compare July 9, 2026 21:33
@claude

claude Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error —— View job


I'll analyze this and get back to you.

@claude

claude Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error —— View job


I'll analyze this and get back to you.

@lalalune lalalune force-pushed the fix/15760-signal-list-accounts branch from f104df9 to cc69471 Compare July 9, 2026 21:55
@claude

claude Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error —— View job


I'll analyze this and get back to you.

@lalalune lalalune merged commit cfa089b into develop Jul 9, 2026
22 checks passed
@lalalune lalalune deleted the fix/15760-signal-list-accounts branch July 9, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants