fix(hitl): recognize real Signal account listings#15768
Merged
Conversation
4 tasks
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
0cee3cf to
f1171d7
Compare
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
f1171d7 to
d9da5ea
Compare
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
d9da5ea to
f09804f
Compare
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
f104df9 to
cc69471
Compare
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to merged #15760 for #14797.
Reviewing the Signal linked-account change against the current upstream CLI exposed two contract mismatches:
listAccountsexit status, but the upstream command returns normally for an empty account collection, so an unlinked CLI could be reported ready;+number/u:usernamelines, while current signal-cli plaintext output isNumber: <account>, so a linked account could be reported absent.The upstream implementation is visible in ListAccountsCommand.java.
This adds a declarative
command-output-nonemptyavailability leaf, carries stdout through the real-machine evaluator, requires actual account-list output, and normalizes the upstreamNumber:prefix before validating and masking account identifiers.Verification
test:lifeops-hitllane: 58/58 passed;git diff --checkpassed;