api: drop the /v1 prefix from every route - #103
Merged
Merged
Conversation
The backend removed the /v1 prefix from the public API routes (ellipsis-dev/ellipsis#6166): everything now answers at /sessions, /reviews, /models, etc. Update every path the CLI builds - the REST client, the WebSocket stream URL, the apiRoutes help lines - plus the tests, docs, skills, and smoke scripts that spell out routes. The one v1 left behind is a comment pointing at the mono repo file ellipsis/src/public_api/routers/v1/v1_router.py, which is a real path, not a route. Config-file 'version: v1' YAML and the v1->v2 config migration are unrelated and untouched. Still pending separately: bump @ellipsis-dev/sdk once 0.6.0 (with the regenerated prefix-free paths) is published from the mono repo.
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed ff1d31c in 3 minutes, 35 seconds.
- Reviewed
1commit with1359lines of code in38files - Ran
1review agent producing0comments where0were posted - This pipeline runs no gatekeeper, so findings are posted as written.
- View full details on ellipsis.dev
This review was created by . You can tag
@ellipsis in this pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backend removed the
/v1prefix from the public API routes (ellipsis-dev/ellipsis#6166): everything now answers at/sessions,/reviews,/models, and so on. This PR updates every path the CLI builds to match.What changed
src/lib/api.tsand the WebSocket stream URL insrc/lib/stream.ts.apiRoutes(...)route lines in every command file, which show in--help.docs/RUN_STREAMING_SPEC.md, both skills, and the smoke scripts. Prose like "the /v1 host" became "the API host" rather than leaving a dangling slash.The one
v1left behind is a comment naming the mono repo fileellipsis/src/public_api/routers/v1/v1_router.py, which is a real path, not a route. Config-fileversion: v1YAML and the v1 -> v2 config migration are unrelated and untouched.Verification
tsc --noEmitis clean and all 435 tests pass (24 files).Follow-ups (not in this PR)
@ellipsis-dev/sdkto^0.6.0once the regenerated SDK is published from the mono repo (the CLI only imports types and stream machinery from it, so it works on 0.5.0, but 0.5.0'sEllipsisClientandpathstype still spell/v1)./v1: the backend deploy needs to keep answering the old paths (or we accept breaking pre-release binaries) until users upgrade.Important
Removes the
/v1prefix from all API routes in the CLI to match the backend's updated public API.src/lib/api.tsand WebSocket stream URL insrc/lib/stream.tsnow use routes without the prefix (e.g.,POST /sessionsinstead ofPOST /v1/sessions).apiRoutes(...)calls across all command files) updated accordingly.ellipsis/src/public_api/routers/v1/v1_router.py, config migration comments about v1→v2).This description was created by
for ff1d31c. It will automatically update as commits are pushed.