skills: catch the conventions and platform docs up to the file rename - #108
Merged
Conversation
`agent asset` became `agent file`, but both skill files still taught the old spelling. That matters more than a stale README: cli-conventions is what a coding agent reads before naming a new command, and the ellipsis skill is what `agent help --interactive` answers from, so each one hands out a command that no longer appears in `--help`. Also documents the rule the rename established, since it was not written down anywhere: a renamed command keeps its old name as a hidden alias. Fixes two smaller staleness bugs found in the same sweep: the ellipsis skill showed `agent review --no-post` with no pull request number, which the server stopped accepting when `pull_request_number` became required, and a comment in types.ts still pointed at `GET /github/members`.
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed f9add74 in 4 minutes, 30 seconds.
- Reviewed
1commit with89lines of code in3files - Ran
1review agent producing0comments where0were posted - This pipeline runs no gatekeeper, so findings are posted as written.
- View full details on ellipsis.dev
This review was created by . You can tag
@ellipsis in this pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #107, which renamed
agent assettoagent file. Both skill files still taught the old spelling, and that matters more than a stale README:skills/cli-conventions/SKILL.mdis what a coding agent reads before naming a new command. It usedagent assetas its worked example throughout, including thealsoKnownAssnippet andDELETE /assets/{id}. It was teaching the singular-noun rule using a command that no longer exists.skills/ellipsis/SKILL.mdis whatagent help --interactiveanswers from, and whatnpx skills add ellipsis-dev/cliinstalls into other agents. It told users to runagent asset upload shot.png.While updating the conventions file I wrote down the rule the rename actually established, which was not documented anywhere: a renamed command keeps its old name as a hidden alias. That is why
agent assetstill works, and the next rename should do the same.Two smaller staleness bugs found in the same sweep:
agent review --no-postwith no pull request number. The server madepull_request_numberrequired (ellipsis#6108), so that form no longer works; corrected toagent review 519 --no-post. Also addedagent review initto the block, since the command exists but was undocumented.src/lib/types.tsstill pointed atGET /github/membersinstead of/integrations/github/members.Test plan
bun run test444 passingskills/,docs/, andREADME.mdforagent asset,<asset-id>,/assets,agent review default, andagents/code_review— no remaining hitsagent assetstill runs as a hidden alias, so the docs and the code agreeIndependent of #107 (branched off
main, no overlapping files), so these can merge in either order.Note:
bun run typecheckreports 4 errors insrc/commands/review.tson this branch. They aremain's pre-existing state, not from this change:maindeclares SDK^0.5.0while #107 is what bumps it to^0.6.0. Confirmed by stashing these edits and re-running. CI installs frommain's lockfile, so it is unaffected, and the errors disappear once #107 merges.Important
Updates skill documentation following the
agent asset→agent filerename from #107.skills/cli-conventions/SKILL.mdupdated with the new command name in all examples, and now documents the rule that renamed commands keep their old name as hidden aliases (the mechanism that letsagent assetstill work).skills/ellipsis/SKILL.mdreflectsagent filein examples and fixes two staleness issues:agent review --no-postnow includes the required PR number, andagent review initadded to the documented commands.src/lib/types.tscomment corrected fromGET /github/memberstoGET /integrations/github/members.This description was created by
for f9add74. It will automatically update as commits are pushed.