Skip to content

skills: catch the conventions and platform docs up to the file rename - #108

Merged
hbrooks merged 1 commit into
mainfrom
docs/catch-skills-up-to-file-rename
Aug 11, 2026
Merged

skills: catch the conventions and platform docs up to the file rename#108
hbrooks merged 1 commit into
mainfrom
docs/catch-skills-up-to-file-rename

Conversation

@hbrooks

@hbrooks hbrooks commented Aug 11, 2026

Copy link
Copy Markdown
Member

Summary

Follow-up to #107, which renamed agent asset to agent file. Both skill files still taught the old spelling, and that matters more than a stale README:

  • skills/cli-conventions/SKILL.md is what a coding agent reads before naming a new command. It used agent asset as its worked example throughout, including the alsoKnownAs snippet and DELETE /assets/{id}. It was teaching the singular-noun rule using a command that no longer exists.
  • skills/ellipsis/SKILL.md is what agent help --interactive answers from, and what npx skills add ellipsis-dev/cli installs into other agents. It told users to run agent asset upload shot.png.

While updating the conventions file I wrote down the rule the rename actually established, which was not documented anywhere: a renamed command keeps its old name as a hidden alias. That is why agent asset still works, and the next rename should do the same.

Two smaller staleness bugs found in the same sweep:

  • The ellipsis skill showed agent review --no-post with no pull request number. The server made pull_request_number required (ellipsis#6108), so that form no longer works; corrected to agent review 519 --no-post. Also added agent review init to the block, since the command exists but was undocumented.
  • A comment in src/lib/types.ts still pointed at GET /github/members instead of /integrations/github/members.

Test plan

  • bun run test 444 passing
  • Swept skills/, docs/, and README.md for agent asset, <asset-id>, /assets, agent review default, and agents/code_review — no remaining hits
  • Verified agent asset still runs as a hidden alias, so the docs and the code agree

Independent of #107 (branched off main, no overlapping files), so these can merge in either order.

Note: bun run typecheck reports 4 errors in src/commands/review.ts on this branch. They are main's pre-existing state, not from this change: main declares SDK ^0.5.0 while #107 is what bumps it to ^0.6.0. Confirmed by stashing these edits and re-running. CI installs from main's lockfile, so it is unaffected, and the errors disappear once #107 merges.

Important

Updates skill documentation following the agent assetagent file rename from #107.

  • skills/cli-conventions/SKILL.md updated with the new command name in all examples, and now documents the rule that renamed commands keep their old name as hidden aliases (the mechanism that lets agent asset still work).
  • skills/ellipsis/SKILL.md reflects agent file in examples and fixes two staleness issues: agent review --no-post now includes the required PR number, and agent review init added to the documented commands.
  • src/lib/types.ts comment corrected from GET /github/members to GET /integrations/github/members.

This description was created by Ellipsis for f9add74. It will automatically update as commits are pushed.

`agent asset` became `agent file`, but both skill files still taught the old
spelling. That matters more than a stale README: cli-conventions is what a
coding agent reads before naming a new command, and the ellipsis skill is what
`agent help --interactive` answers from, so each one hands out a command that no
longer appears in `--help`.

Also documents the rule the rename established, since it was not written down
anywhere: a renamed command keeps its old name as a hidden alias.

Fixes two smaller staleness bugs found in the same sweep: the ellipsis skill
showed `agent review --no-post` with no pull request number, which the server
stopped accepting when `pull_request_number` became required, and a comment in
types.ts still pointed at `GET /github/members`.
@hbrooks
hbrooks merged commit 54c7182 into main Aug 11, 2026
1 check passed

@ellipsis-dev ellipsis-dev Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed f9add74 in 4 minutes, 30 seconds.
  • Reviewed 1 commit with 89 lines of code in 3 files
  • Ran 1 review agent producing 0 comments where 0 were posted
  • This pipeline runs no gatekeeper, so findings are posted as written.
  • View full details on ellipsis.dev

This review was created by Ellipsis. You can tag @ellipsis in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant