connect: semantic relay only, remove --raw/ttyd#38
Merged
Conversation
- connect.ts: drop --raw and runConnectRaw; the action always runs the semantic runConnect (now exported). Remove terminal.ts import. - session.tsx: start --connect uses semantic runConnect instead of a raw ttyd attach; update option/help copy. - delete src/lib/terminal.ts and test/terminal.test.ts (ttyd byte-bridge).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the raw-PTY / ttyd terminal attach from
agent session connect. Connect is now a semantic relay only: it renders the session's structured events and sends input as messages over the inbox — no ttyd byte bridge, no--raw.Companion backend PR: ellipsis-dev/ellipsis#5814 (keeps
/streamopen across turns, removes the server-side ttyd routes/module).Changes
connect.ts: removed the--rawoption andrunConnectRaw; the command always runs the semanticrunConnect. ExportedrunConnectfor reuse.session.tsx:session start --connectnow uses the semanticrunConnect(was a raw ttyd attach).src/lib/terminal.ts(the ttyd WebSocket byte-bridge) and its test.Why
Raw PTY can't do multi-viewer-at-independent-sizes, ordered/attributed multi-sender, or "can't exit the session"; the semantic relay gives all three. See the backend PR / the
ellipsis-internal-cliskill decision.Validation
tsc --noEmitclean,tsupbuild success,vitest188 tests pass.runConnectRaw/attachTerminal/ttyd/--raw.