connect: start with mouse capture off so links and select work#75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Flip the default so the connect TUI starts with terminal mouse reporting off.
Why
Arming mouse reporting (xterm modes 1000/1006) is the only way to receive scroll-wheel events, but the protocol has no wheel-only mode: mode 1000 forwards every mouse event to the app, so clicks, text selection, and clickable links all stop working. The app swallows those events, which is why "clicking links and a bunch of other stuff" broke while scrolling worked.
There is no way to keep both native mouse behavior and wheel scrolling at once, so this makes the more common case (clicking links / selecting text) the default.
Change
mouseCapturenow startsfalse— the terminal keeps the mouse for links and copy/paste out of the box.ctrl+sarms wheel scrolling of the transcript (unchanged mechanism; just the default is flipped).Test
bun run test(260 passing)tsc --noEmitclean