skills: rewrite the public Ellipsis skill against the new docs - #98
Merged
Conversation
The docs rewrite (ellipsis#6101) reorganized everything product by product, and the old skill had drifted from it: `limits` instead of `budget`, plural `triggers`, `agent hooks`/`agent integrations` for what are now singular, and code review missing entirely even though it is one of the two products. Rewritten from the 59 new pages, with every command, flag, field, and number verified against source rather than ported: - Code review gets its own section: the org-wide toggle, the pipeline stages, and the overlay merge rules that actually catch people out (declaring `pull_requests:` is authoritative, unset vs `filter: []`). - `agent review` is documented at all, including the tree review and its sidecar branch. - Triggers cover all six react surfaces, the watch set vs clone set distinction, and the `for` default that excludes bots. - Every config example validates through the real production validators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rewrites
skills/ellipsis/SKILL.mdfrom scratch against the docs rewrite in ellipsis-dev/ellipsis#6101. The old skill was written against the Diátaxis tree and had drifted from the product.Why it needed a rewrite, not an edit
The old skill was wrong in ways a reader would act on:
limits:instead ofbudget:, and pluraltriggers:instead oftrigger:. Both fail validation today.agent hooks,agent integrations,agent analytics reviewersfor what are singular commands./docs/get-startedand/docs/referencetrees.agent review, the whole on-demand review surface.What is in the new one
Structured to match how the docs are now organized: what Ellipsis is, agents as code, triggers, code review, the CLI, writing a config, sandboxes and permissions, skills, in-sandbox behavior.
New coverage the old skill lacked:
pull_requests:is authoritative (a non-matching PR gets no review, not the built-in one); unsetfilter:inherits the gatekeeper whilefilter: []disables it.agent review: reviewing a PR by number, and the bare form that snapshots your working tree to anellipsis/review/<branch>sidecar.fordefault ofusers: true, bots: false.dockerfile_append/image.setup/hooksis cached and which is not, since that is the difference between a warm start and a 10-minute install every session.Verification
Nothing was ported on trust. Against this repo's actual binary:
--helpon each).Against the backend's real validators:
AgentConfig.from_yaml/CodeReviewConfig.from_yaml.claude-opus-5default, $250 session default and platform max, $1k/$10k/$40k trailing ceilings, $10 defaultbudget.run, 8-reviewer cap, cpu 0.125-16, memory 512MB-64GB, timeout 60s-1h, 600simage.setupand 300s hook caps, 10 skills / 50 files / 512 KiB / 64 KiB, the six react surfaces, and all six exit statuses named.House style: no em dashes, none of
simply,easily,just,powerful.Note
agent config validateis deliberately not documented here. It is still uncommitted work in the tree andPOST /v1/configs/validatecurrently 405s, so documenting it would be a promise the CLI cannot keep. Worth adding in the PR that ships it.