chore: update tx_service for deferred scan read release - #536
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe ChangesData substrate update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@data_substrate`:
- Line 1: Update the data_substrate gitlink from
c833ee20a64c7d4d3c50664f642eb33934d3eb33 to the finalized tx_service#526
squash-merge commit 3427a03.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
11e3c5c to
d5bc28e
Compare
Context
Companion to merged eloqdata/tx_service#526 and eloqdata/tx_service#508. EloqKV consumes the fix through the
data_substratesubmodule.Behavior before and after
Before: later hash-scan batches could redundantly re-enter an already completed CC-map memory source while store buckets were unfinished.
After: scan ownership remains until transaction finalization, and completed hash memory sources are skipped without adding another
ReadIntent.Implementation
Advance
data_substrateto tx_servicemaincommit87ed815, the squash-merge result of eloqdata/tx_service#526. No EloqKV source code changes.Design decisions and alternatives
Keep the engine fix entirely in tx_service; EloqKV only updates the gitlink.
Test plan
Commands and results:
The final EloqKV CI run was triggered before merge. The required cpplint and formatting checks passed; remaining integration jobs were still running when merged per maintainer direction.
Risk assessment
No EloqKV API, protocol, WAL, storage-format, or configuration changes. Runtime risk is limited to the tx_service scan behavior reviewed and tested in #526.
Rollback plan
Revert this gitlink update.
Reviewer guide
Verify
data_substratepoints to87ed815, which is reachable from tx_servicemain.Follow-up work
None.