Skip to content

Comments

fix: put deleted keys with ttl when mvcc is enabled#208

Closed
thweetkomputer wants to merge 1 commit intoeloqdata:eloq-10.6.10from
thweetkomputer:fix-range-putall-zc
Closed

fix: put deleted keys with ttl when mvcc is enabled#208
thweetkomputer wants to merge 1 commit intoeloqdata:eloq-10.6.10from
thweetkomputer:fix-range-putall-zc

Conversation

@thweetkomputer
Copy link
Collaborator

@thweetkomputer thweetkomputer commented Jan 14, 2026

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies to their latest versions.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026

Walkthrough

This PR updates the data_substrate submodule reference to a newer commit hash (3892ee23e527cab9fdd4824ddd78b2328605420c). No functional changes, control-flow modifications, or API alterations were introduced.

Changes

Cohort / File(s) Summary
Submodule Reference Update
data_substrate
Updated submodule commit pointer from 25dd6a39cedb036e8ce849509245769fbcea48c7 to 3892ee23e527cab9fdd4824ddd78b2328605420c

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • update subm #185 — Updates the same data_substrate submodule pointer with no functional changes
  • update subm #189 — Performs an identical submodule reference update for data_substrate
  • update submodule #174 — Updates the data_substrate submodule commit hash with no functional modifications

Suggested labels

trigger-ci

Suggested reviewers

  • lzxddz
  • xiexiaoy

Poem

🐰 A hop, a skip, a pointer's dance,
Submodules twirl in their Git trance,
No logic bent, no function bent,
Just upstream code that went up went!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title claims to fix deleted keys with TTL when MVCC is enabled, but the actual change only updates a submodule reference with no functional changes. Update the title to accurately reflect that this is a submodule update, such as 'chore: update data_substrate submodule' or provide the actual functional changes that implement the described fix.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 95e9268 and 7f3c7ed.

📒 Files selected for processing (1)
  • data_substrate
🔇 Additional comments (1)
data_substrate (1)

1-1: Verify the submodule update aligns with the stated fix and confirm integration testing.

The data_substrate submodule reference has been updated (commit 25dd6a3 → 3892ee2), but the PR title indicates a functional fix for "deleted keys with ttl when mvcc is enabled." Ensure that:

  • The commits in the tx_service repository between these two points address the stated issue
  • Integration tests covering the MVCC and deleted keys with TTL behavior have been run with the updated submodule

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant