adapt to boost context asan new install path - #322
Conversation
|
Warning Rate limit exceeded@thweetkomputer has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 17 minutes and 38 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe CMake build script refactors ASAN Boost Context library resolution, replacing environment-variable-based paths with dynamic library discovery via Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
store_handler/eloq_data_store_service/build_eloq_store.cmake
🔇 Additional comments (2)
store_handler/eloq_data_store_service/build_eloq_store.cmake (2)
43-43: LGTM!The debug message provides useful visibility into which Boost Context library is being used during configuration.
25-37: LGTM!The ASAN configuration is well-structured:
- Compile and link options are correctly applied.
- Library discovery uses
find_libraryfor portability instead of hardcoded paths.- Proper
FATAL_ERRORensures clear failure if the ASAN-specific library is missing.
Here are some reminders before you submit the pull request
fixes eloqdb/tx_service#issue_id./mtr --suite=mono_main,mono_multi,mono_basicSummary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.