Skip to content

adapt to boost context asan new install path - #322

Merged
thweetkomputer merged 3 commits into
mainfrom
asan_zc
Dec 25, 2025
Merged

adapt to boost context asan new install path#322
thweetkomputer merged 3 commits into
mainfrom
asan_zc

Conversation

@thweetkomputer

@thweetkomputer thweetkomputer commented Dec 25, 2025

Copy link
Copy Markdown
Collaborator

Here are some reminders before you submit the pull request

  • Add tests for the change
  • Document changes
  • Reference the link of issue using fixes eloqdb/tx_service#issue_id
  • Reference the link of RFC if exists
  • Pass ./mtr --suite=mono_main,mono_multi,mono_basic

Summary by CodeRabbit

Release Notes

  • Chores
    • Refined Address Sanitizer build configuration with improved library discovery mechanisms and enhanced linking options for greater build reliability.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Dec 25, 2025

Copy link
Copy Markdown

Warning

Rate limit exceeded

@thweetkomputer has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 17 minutes and 38 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between eca051c and 46fc032.

📒 Files selected for processing (1)
  • store_handler/eloq_data_store_service/build_eloq_store.cmake

Walkthrough

The CMake build script refactors ASAN Boost Context library resolution, replacing environment-variable-based paths with dynamic library discovery via find_library(), adds explicit error handling for missing libraries, and updates compiler/linker flag configuration.

Changes

Cohort / File(s) Summary
Build Configuration - ASAN Boost Context Resolution
store_handler/eloq_data_store_service/build_eloq_store.cmake
Switched from HOME-based path lookup to find_library() for locating libboost_context-asan in ASAN mode; replaced CMAKE_CXX_FLAGS_ASAN with explicit add_compile_options() and add_link_options() calls; added fatal error when ASAN library not found; updated non-ASAN path to discover boost_context via find_library() instead of requiring Boost package; introduced BOOST_CONTEXT_TARGET variable for consistent library targeting; added debug message output.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • link correct lib for asan #286: Directly modifies the same build logic in store_handler/eloq_data_store_service to refactor ASAN-era Boost.Context resolution and update library linkage strategy.

Suggested reviewers

  • yi-xmu

Poem

🐰 A CMake quest, both swift and bright,
We find our Boost with newfound might,
ASAN guards the build with care,
No paths lost in the system air,
Our flags are set, our errors clear,
The context library now draws near!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only the template checklist with no substantive content, implementation details, or rationale explaining the changes made. Add a clear explanation of why the change was needed, how the new ASAN Boost.Context discovery method works, and why the previous environment-based path approach was replaced.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adapting the build system to handle a new installation path for the ASAN-built Boost.Context library.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 962d604 and eca051c.

📒 Files selected for processing (1)
  • store_handler/eloq_data_store_service/build_eloq_store.cmake
🔇 Additional comments (2)
store_handler/eloq_data_store_service/build_eloq_store.cmake (2)

43-43: LGTM!

The debug message provides useful visibility into which Boost Context library is being used during configuration.


25-37: LGTM!

The ASAN configuration is well-structured:

  • Compile and link options are correctly applied.
  • Library discovery uses find_library for portability instead of hardcoded paths.
  • Proper FATAL_ERROR ensures clear failure if the ASAN-specific library is missing.

Comment thread store_handler/eloq_data_store_service/build_eloq_store.cmake

@githubzilla githubzilla left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@thweetkomputer
thweetkomputer merged commit 4943d80 into main Dec 25, 2025
4 checks passed
@thweetkomputer
thweetkomputer deleted the asan_zc branch December 25, 2025 06:45
@coderabbitai coderabbitai Bot mentioned this pull request Mar 23, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants