This repository was archived by the owner on Jul 8, 2023. It is now read-only.
Default return values for basic iterators, generators, and SPL containers. - #139
Merged
Conversation
… built-in datastructure types (fixes #138).
jmalloc
force-pushed
the
feature/traversable-defaults
branch
from
March 5, 2016 07:32
29de4a7 to
5487c93
Compare
Contributor
|
Could you just check the coverage for me? Should be good to merge otherwise. |
Member
Author
|
|
jmalloc
added a commit
that referenced
this pull request
Mar 5, 2016
Default return values for basic iterators, generators, and SPL containers.
Contributor
|
I forgot to ask you to update the relevant documentation, and the changelog. Not a big deal, but I like to keep them all on the same commit if possible. Oh well, next time. |
ezzatron
added a commit
that referenced
this pull request
Mar 6, 2016
ezzatron
added a commit
that referenced
this pull request
Mar 7, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #138
This might need some feature detection around the generator stuff, though it obviously only works in PHP 7 with return type values anyway - waiting to see how the HHVM builds go on Travis CI.