Skip to content

Add syntax highlight not supported by current php-mode #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zonuexe merged 2 commits into from
Feb 6, 2018
Merged

Add syntax highlight not supported by current php-mode #413

zonuexe merged 2 commits into from
Feb 6, 2018

Conversation

@zonuexe
Copy link
Member

@zonuexe zonuexe commented Feb 5, 2018

I am aware that this problem is caused by #401, but it is also true that this testing method is unstable.

@ghost
Copy link

ghost commented Feb 5, 2018

I forgot the _ character in the regexp at line 1568 and 1569. See https://github.com/ejmr/php-mode/blob/master/php-mode.el#L1568. Adding this should fix the test.

@zonuexe
Fix regexp for constant font-locking
79cb812 
This fix is not essential, we will redesign at a later date.
@zonuexe zonuexe merged commit 5598dd3 into emacs-php:master Feb 6, 2018
@zonuexe zonuexe deleted the fix/fallen-test branch February 6, 2018 06:47
@zonuexe
Copy link
Member Author

zonuexe commented Feb 6, 2018

@fallchildren Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@zonuexe