Skip to content

fix some font-lock and indentation issues in emacs 25 #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zonuexe merged 6 commits into from Feb 1, 2018
Merged

fix some font-lock and indentation issues in emacs 25 #401

zonuexe merged 6 commits into from Feb 1, 2018

Conversation

@ghost
Copy link

@ghost ghost commented Jan 22, 2018

fallchildren and others added 3 commits January 23, 2018 00:27
fix some font-lock and indentation issues in emacs 25
c9601d9 
- Removed advice "font-lock-fontify-keywords-region" (fixes GitHub Issue: #280)
- Changed syntax-propertize code to work with emacs 25 (fixes GitHub Issue: #371)
- Necessary code changes to replace the advice (font-locking for namespaces)
@fallchildren
fix compilation error
96bf2b0 
"php-heredoc-start-re" must be defined when compiled and run, else macroexpansion fails at compile time.
@fallchildren
fix tests
2b8b0ea
@ghost
Copy link
Author

ghost commented Jan 23, 2018

For me it seems this has also fixed Github Issue: #390. Tested with current git master and Emacs 24.4.1.

@zonuexe
Copy link
Member

zonuexe commented Jan 23, 2018

@fallchildren Thanks for your contribution!
I will take some time to review it, so please wait a while.

@zonuexe zonuexe self-requested a review January 23, 2018 15:33
@ghost ghost mentioned this pull request Jan 31, 2018
Closed
@zonuexe zonuexe merged commit fdf5ed0 into emacs-php:master Feb 1, 2018
@zonuexe
Copy link
Member

zonuexe commented Feb 1, 2018

@fallchildren Thanks!
I merged this patch to the master. I am worried that this change will destroy someone's environment, but we would like to wait for more feedback from users.

Please wait for a while to release this change as a stable version.

@ghost
Copy link
Author

ghost commented Feb 1, 2018

@zonuexe Cool stuff, thank!
I hope it does not. I've been using it productively for a week or so and it did not break anything for me "yet". My experience so far is that it is more stable for emacs25 and master. But who knows. If there are any problems, feel free to contact me.

This was referenced Feb 5, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zonuexe zonuexe Awaiting requested review from zonuexe

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zonuexe @fallchildren