Skip to content

Conversation

@zonuexe
Copy link
Member

@zonuexe zonuexe commented May 18, 2019

refs #524

Example

diff --git a/php-mode-test.el b/php-mode-test.el
index 98fe95c..0e760be 100644
--- a/php-mode-test.el
+++ b/php-mode-test.el
@@ -930,7 +930,8 @@ style from Drupal."
 (ert-deftest php-mode-test-issue-443 ()
   "This case allows you to color things that are not authentic PHP tags
 (ex.  `<?xml', `<?hh') as false positives."
-  (with-php-mode-test ("issue-443.php" :faces t)))
+  (with-php-mode-test ("issue-443.php"
+                       :faces (if (version<= "27" emacs-version) ".27.faces" t))))

 (ert-deftest php-mode-test-type-hints ()
   "Test highlighting of type hints and return types."

When the condition is met, issue-443.php is loaded as "facelist". t is just replaced by .faces.

@zonuexe zonuexe force-pushed the feature/test-another-facelist branch from 6fc04fa to 5613f17 Compare May 18, 2019 00:12
@zonuexe zonuexe merged commit 89b9d34 into master May 18, 2019
@zonuexe zonuexe deleted the feature/test-another-facelist branch May 18, 2019 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants