Skip to content

Conversation

@mallt
Copy link
Contributor

@mallt mallt commented May 18, 2019

This PR fixes #524 by handling the changed comment delimiter in emacs 27.

@mallt
Copy link
Contributor Author

mallt commented May 18, 2019

@zonuexe Thanks for the change in the with-php-mode-test macro! It seems however if the :faces condition evaluates to t a (wrong-type-argument sequencep t) error is raised during test execution on older emacs versions.

Do you know how we can circumvent this error? Thanks!

@zonuexe
Copy link
Member

zonuexe commented May 18, 2019

@mallt I'm sorry, that was my mistake at #526, I just fixed in #528. Could you rebase this PR?

@mallt mallt force-pushed the fix-test-443-emacs-27 branch from 0711f11 to 68d5c8e Compare May 18, 2019 16:25
@mallt
Copy link
Contributor Author

mallt commented May 18, 2019

@zonuexe Thanks a lot for the fix! All checks are green now. :)

@zonuexe zonuexe merged commit 095987a into emacs-php:master May 18, 2019
@zonuexe
Copy link
Member

zonuexe commented May 18, 2019

@mallt Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test for issue 443 on emacs 27

2 participants