-
Notifications
You must be signed in to change notification settings - Fork 12
Use :async to company-phpactor, Version 2 #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@zonuexe It worked so well! Thanks 👍 |
phpactor.el
Outdated
| (unless (file-exists-p (expand-file-name ".gitignore" phpactor-install-directory)) | ||
| (f-write-text "*\n" 'utf-8 (expand-file-name ".gitignore" phpactor-install-directory))) | ||
| (cl-loop for file in '("composer.json" "composer.lock") | ||
| (cl-loop for file in '("composer.json") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one leaves me doubtful. Why remove composer.lock and why do it here ?
|
just tested, seems to work well. On code level, I will trust you as I'm not used to async and a bit short of time to dive into it :-) Only thing that worries me is that line with composer.lock being removed : as far as I understand, its purpose is to get identical installations of dependencies for everyone, and that sounds to me as a good thing, so what's the reason to remove it ? |
|
|
refs #129
This PR was based on #129 and made function calls asynchronous using
asyncpackage. (Thanks @nanasess)